Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update Apache License for mshadow #18109

Merged
merged 5 commits into from
Apr 22, 2020
Merged

Update Apache License for mshadow #18109

merged 5 commits into from
Apr 22, 2020

Conversation

ciyongch
Copy link
Contributor

Description

Update Apache License for mshadow as described in #17329.

@TaoLv @pengzhao-intel @szha

@mxnet-bot
Copy link

Hey @ciyongch , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, sanity, clang, unix-gpu, website, edge, miscellaneous, windows-gpu, windows-cpu, centos-gpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ciyongch ciyongch mentioned this pull request Apr 20, 2020
Closed
11 tasks
@ciyongch
Copy link
Contributor Author

Ping @mjwall as well.

I will backport this PR to v1.x and v1.7.x branch later.

@ciyongch
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@leezu
Copy link
Contributor

leezu commented Apr 20, 2020

Please update the RAT license checker to enforce license in the 3rdparty/mshadow folder

Ie need to fix this line

https://github.com/apache/incubator-mxnet/blob/6198d1d7e10ba58ccc64ab7701d0c528b64bd58e/tests/nightly/apache_rat_license_check/rat-excludes#L34

leezu
leezu suggested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@leezu leezu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ciyongch ! Let's have a mechanism to ensure the mshadow folder stays compliant (ie. disable the exclusion in rat?)

@ciyongch
Copy link
Contributor Author

Thanks @ciyongch ! Let's have a mechanism to ensure the mshadow folder stays compliant (ie. disable the exclusion in rat?)

@leezu Thanks for point it out, I've updated the rat-excludes to enable check for mshadow, and keep the rest of folders under 3rdparty unchanged. Not sure if there's any other elegant way to handle this.

@leezu
Copy link
Contributor

leezu commented Apr 21, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@ciyongch
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu ]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ciyongch
Copy link
Contributor Author

@TaoLv @pengzhao-intel @nswamy @szha Please help to take a review, thanks.

@pengzhao-intel
Copy link
Contributor

Looks and merging now.

@pengzhao-intel pengzhao-intel merged commit 6a809aa into apache:master Apr 22, 2020
@ciyongch ciyongch deleted the fix_license branch April 22, 2020 06:11
ciyongch added a commit to ciyongch/incubator-mxnet that referenced this pull request Apr 22, 2020
@ciyongch
Update Apache License for mshadow (apache#18109)
0f36155 
* Add Apache License for mshadow

* update cpp-package license

* udpate license for mx-theme in top-level LICENSE

* Enable RAT License check for mshadow, and keep the rest of 3rdparty unchanged.

* add license header
@ciyongch ciyongch mentioned this pull request Apr 22, 2020
Merged
ciyongch added a commit to ciyongch/incubator-mxnet that referenced this pull request Apr 22, 2020
@ciyongch
Update Apache License for mshadow (apache#18109)
db02752 
* Add Apache License for mshadow

* update cpp-package license

* udpate license for mx-theme in top-level LICENSE

* Enable RAT License check for mshadow, and keep the rest of 3rdparty unchanged.

* add license header
@ciyongch ciyongch mentioned this pull request Apr 22, 2020
Merged
leezu pushed a commit that referenced this pull request Apr 24, 2020
@ciyongch
Update Apache License for mshadow (#18109) (#18134)
38e6634 
* Add Apache License for mshadow

* update cpp-package license

* udpate license for mx-theme in top-level LICENSE

* Enable RAT License check for mshadow, and keep the rest of 3rdparty unchanged.

* add license header
pengzhao-intel pushed a commit that referenced this pull request Apr 24, 2020
@ciyongch
Update Apache License for mshadow (#18109) (#18133)
f765e8a 
* Add Apache License for mshadow

* update cpp-package license

* udpate license for mx-theme in top-level LICENSE

* Enable RAT License check for mshadow, and keep the rest of 3rdparty unchanged.

* add license header
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@ciyongch @AntiZpvoh
Update Apache License for mshadow (apache#18109)
5fde67d 
* Add Apache License for mshadow

* update cpp-package license

* udpate license for mx-theme in top-level LICENSE

* Enable RAT License check for mshadow, and keep the rest of 3rdparty unchanged.

* add license header
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TaoLv TaoLv TaoLv approved these changes

@leezu leezu leezu approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ciyongch @mxnet-bot @leezu @pengzhao-intel @TaoLv